[Enhancement] Define some default values uniformly #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yandongxiao
requested review from
dengliu and
kevincai
and removed request for
dengliu
yandongxiao
force-pushed
the
enhancement/define-default-values-uniformly
branch
from
a5ff654 to
3d15606
Compare
dengliu
reviewed
Jan 29, 2024
| @@ -61,7 +106,7 @@ starrocksFESpec: | |||
| image: | |||
| # image sliced by "repository:tag" | |||
| repository: starrocks/fe-ubuntu | |||
| tag: 3.1-latest | |||
| tag: "" | |||
There was a problem hiding this comment.
if we set it to empty string. will it also take precedence over the values in componentValues?
There was a problem hiding this comment.
No. Only when it has a non-empty value.
dengliu
approved these changes
Jan 29, 2024
mingmxu
reviewed
Jan 29, 2024
| # - key: metadata.name | ||
| # operator: In | ||
| # values: | ||
| # - target-host-name |
There was a problem hiding this comment.
Let's add podLabels as well.
yandongxiao
force-pushed
the
enhancement/define-default-values-uniformly
branch
from
3d15606 to
05deb8f
Compare
Signed-off-by: yandongxiao <[email protected]>
yandongxiao
force-pushed
the
enhancement/define-default-values-uniformly
branch
from
05deb8f to
f5c450d
Compare
kevincai
reviewed
Jan 30, 2024
| Get the value of the nodeSelector field in the starrocksFESpec | ||
| */}} | ||
| {{- define "starrockscluster.fe.nodeSelector" -}} | ||
| {{- if .Values.starrocksFESpec.nodeSelector -}} |
There was a problem hiding this comment.
this is a complete replace behavior, not the merge together behavior, need explicit this in the values.yaml comments.
Otherwise, the user can define some of the common criteria in compontValues and add additional specific criteria in each XXSpec and expect the final result is the merge-replace output.
The same applies to hostAlias/Labels/affinity ...
Signed-off-by: yandongxiao <[email protected]>
kevincai
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the individual spec definitions of the sub-components, there are indeed many fields with the same name, such as image, imagePullSecrets, nodeSelector, schedulerName. Generally, the contents of these fields are consistent in the individual spec definitions of the sub-components.
Fixes: #424
Checklist
For helm chart, please complete the following checklist:
file of starrocks chart.
scriptsdirectory, runbash create-parent-chart-values.shto update the values.yaml file of the parentchart( kube-starrocks chart).