[BugFix] Allow to remove some resources limit, like cpu #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dengliu
approved these changes
Jan 30, 2024
kevincai
reviewed
Jan 30, 2024
| {{- else if .Values.starrocksCnSpec.resource }} | ||
| {{- include "starrockscluster.cn.resources" . | nindent 4 }} | ||
| {{- end }} | ||
| {{- if .Values.starrocksCnSpec.resource }} |
There was a problem hiding this comment.
should merge the two if statements into a single if..end?
yandongxiao
force-pushed
the
bugfix/make-it-possible-to-remove-resource-limit
branch
from
f871641 to
8ac069c
Compare
kevincai
reviewed
Jan 30, 2024
| {{- define "starrockscluster.cn.resources" -}} | ||
| resources: | ||
| requests: | ||
| {{- range $key, $value := .Values.starrocksCnSpec.resources.requests }} |
There was a problem hiding this comment.
why not directly toYaml here since there is no specific processing to the key/value.
There was a problem hiding this comment.
No special reason, just keep same with limits.
I will try to change to toYaml
Signed-off-by: yandongxiao <[email protected]>
yandongxiao
force-pushed
the
bugfix/make-it-possible-to-remove-resource-limit
branch
from
8ac069c to
65328f7
Compare
kevincai
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Fixes: #422
Checklist
For helm chart, please complete the following checklist:
file of starrocks chart.
scriptsdirectory, runbash create-parent-chart-values.shto update the values.yaml file of the parentchart( kube-starrocks chart).