-
Notifications
You must be signed in to change notification settings - Fork 74
[Feature][issue-423] add datadog profiling to SR Helm #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yandongxiao
merged 4 commits into
StarRocks:main
from
mingmxu:issue-423/datadog-helm-conf
Feb 4, 2024
Merged
[Feature][issue-423] add datadog profiling to SR Helm #437
yandongxiao
merged 4 commits into
StarRocks:main
from
mingmxu:issue-423/datadog-helm-conf
Feb 4, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
073bf18
to
5aa4928
Compare
yandongxiao
reviewed
Feb 1, 2024
helm-charts/charts/kube-starrocks/charts/starrocks/templates/starrockscluster.yaml
Outdated
Show resolved
Hide resolved
helm-charts/charts/kube-starrocks/charts/starrocks/templates/starrockscluster.yaml
Outdated
Show resolved
Hide resolved
helm-charts/charts/kube-starrocks/charts/starrocks/templates/starrockscluster.yaml
Outdated
Show resolved
Hide resolved
helm-charts/charts/kube-starrocks/charts/starrocks/templates/starrockscluster.yaml
Outdated
Show resolved
Hide resolved
I would like to ask, what is your screenshot tool? |
It's the
|
54df260
to
cc1e56d
Compare
run bash create-parent-chart-values.sh Signed-off-by: Mingmin Xu <[email protected]>
Signed-off-by: Mingmin Xu <[email protected]>
Signed-off-by: Mingmin Xu <[email protected]>
add dd_profile in CN pods Signed-off-by: Mingmin Xu <[email protected]>
cc1e56d
to
e2f66b1
Compare
yandongxiao
reviewed
Feb 4, 2024
@@ -282,6 +287,13 @@ starrocksCnSpec: | |||
# If runAsNonRoot is true, the container is run as non-root user. | |||
# The userId will be set to 1000, and the groupID will be set to 1000. | |||
runAsNonRoot: false | |||
# add/drop capabilities for CN container. | |||
capabilities: { } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an space in { }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add datadog_profiling options in Helm chart to simplify the settings to enable dd profiling.
Related Issue(s)
Please list any related issues and link them here.
Checklist
For operator, please complete the following checklist:
make generate
to generate the code.golangci-lint run
to check the code style.make test
to run UT.make manifests
to update the yaml files of CRD.For helm chart, please complete the following checklist:
file of starrocks chart.
scripts
directory, runbash create-parent-chart-values.sh
to update the values.yaml file of the parentchart( kube-starrocks chart).
-----Test Plan----
helm lint
helm template
with settings on/off, and see the diff ofhelm template starrocks .
apply the new
StarRocksCluster
yaml----Revision 2 Test Plan-------
starrocksBeSpec.capabilities
in values to confirm it's merged correctlySee output as below
----revision 4 test plan-----
switch
enabledBe/enabledCn: true/false
, plus with additional capabilitiesThe diff of helm template is shown as below:

Dry-run