[BugFix] Try to use different version to delete HPA #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yandongxiao <[email protected]>
yandongxiao
force-pushed
the
bugfix/try-to-use-different-version-to-delete-hpa
branch
from
25d0de3 to
5519559
Compare
kevincai
approved these changes
Mar 14, 2024
This was referenced Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If we mistakenly determine the type of HPA, we will receive an error message similar to "no matches for kind 'HorizontalPodAutoscaler' in version 'autoscaling/v2beta2'".
This error cannot be identified through apierrors, and using string comparison to determine if it is this error is not a good approach. Therefore, our solution is to always switch to another version of HPA for deletion.
Checklist
For operator, please complete the following checklist:
make generateto generate the code.golangci-lint runto check the code style.make testto run UT.make manifeststo update the yaml files of CRD.