Skip to content

[Feature] Support init Containers #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yandongxiao
Copy link
Collaborator

Description

In some cases, we need to update the configuration of the host machine. For example, in order to collect Core Dump files, we need to set /proc/sys/kernel/core_pattern in the host environment. There are two options available:

  1. Start StarRocks Component with privileged root permission and run it continuously with that permission. This requires the Operator to have the ability to change the entrypoint script.
  2. Before starting StarRocks Component, start a privileged root init container first. This method provides higher security.

Checklist

For operator, please complete the following checklist:

  • run make generate to generate the code.
  • run golangci-lint run to check the code style.
  • run make test to run UT.
  • run make manifests to update the yaml files of CRD.

@yandongxiao yandongxiao force-pushed the enhancement/support-init-containers branch 3 times, most recently from 4970b37 to a68e05b Compare April 2, 2024 05:47
@yandongxiao yandongxiao force-pushed the enhancement/support-init-containers branch from a68e05b to 957e28d Compare April 2, 2024 05:48
@yandongxiao yandongxiao requested review from dengliu and kevincai April 2, 2024 07:57
@yandongxiao yandongxiao marked this pull request as ready for review April 7, 2024 09:27
@yandongxiao yandongxiao merged commit d5fb6d3 into StarRocks:main Apr 9, 2024
6 checks passed
@dengliu
Copy link
Collaborator

dengliu commented Apr 9, 2024

@yandongxiao when will this be release in the helm chart and CRD?
cc @mingmxu

@yandongxiao
Copy link
Collaborator Author

‌‌Should be by the end of this week or early next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants