Skip to content

update comments and order #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

DanRoscigno
Copy link
Contributor

@DanRoscigno DanRoscigno commented Jun 3, 2024

Description

I was confused by the wording about HPA and replicas, I shortened it and I hope it makes sense to everyone, please check.

I also reordered the resources sections to that all of them are in the same order as the FE (requests then limits).

Related Issue(s)

Please list any related issues and link them here.

Checklist

For operator, please complete the following checklist:

  • run make generate to generate the code.
  • run golangci-lint run to check the code style.
  • run make test to run UT.
  • run make manifests to update the yaml files of CRD.

For helm chart, please complete the following checklist:

  • make sure you have updated the values.yaml
    file of starrocks chart.
  • In scripts directory, run bash create-parent-chart-values.sh to update the values.yaml file of the parent
    chart( kube-starrocks chart).

Signed-off-by: DanRoscigno <[email protected]>
@yandongxiao yandongxiao merged commit aea23c3 into StarRocks:main Jun 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants