Suggested edits to test suite to use NB_PREFIX #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move injection of NB_PREFIX in containers from TrackedContainer object to container() fixture and pull default NB_PREFIX value from environment (similar to IMAGE_NAME). * Add debug printing to test_server_alive to more clearly show which tests pass/fail
* Add dev/imagename endpoint in Makefile to make it easier to run local versions of notebooks. Also handles NB_PREFIX explicitly and prompts users with the correct local link to log into their server * Add NB_PREFIX to the test endpoint of Makefile to allow for testing with/without NB_PREFIX
Add clickable link to dev output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested edits to test suite to use NB_PREFIX