implement JavaInt conformance to JavaParameterConvertible #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le, use JavaInt instead
ephemer
reviewed
Aug 16, 2018
|
|
||
| extension Int: JavaParameterConvertible, JavaInitializableFromMethod, JavaInitializableFromField { | ||
| extension JavaInt: JavaParameterConvertible, JavaInitializableFromMethod, JavaInitializableFromField { | ||
| public static var asJNIParameterString = "I" | ||
|
|
||
| public func toJavaParameter() -> JavaParameter { | ||
| return JavaParameter(int: JavaInt(self)) |
There was a problem hiding this comment.
this can now just read int: self
ephemer
reviewed
Aug 16, 2018
| let result = try jni.GetStaticIntField(of: javaClass, id: fieldID) | ||
| return Int(result) | ||
| return JavaInt(result) |
There was a problem hiding this comment.
I think these can be directly returned now return try jni.GetStaticIntField(of: javaClass, id: fieldID)
ephemer
approved these changes
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaking change: Int does no longer conform to JavaParameterConvertible use JavaInt instead