allows static method calls on JNIObject
#14
Conversation
| try checkAndThrowOnJNIError() | ||
| self.javaClass = javaClass! | ||
| self.instance = globalInstanceRef | ||
| } | ||
|
|
There was a problem hiding this comment.
looks good overall, but we should deprecate the current convenience init and force use of the new API where users have to override className (it's weird to have a convenience init with className here)
There was a problem hiding this comment.
I think the best way to do that would be to add
@available(*, deprecated, message: "Override Self.className instead and use the initializers that don't take className as an argument")
convenience public init(_ className: String, arguments: [JavaParameterConvertible] = []) throws {
// deprecated init
}
// note the variadic arguments syntax instead of the array
convenience public init(...arguments: [JavaParameterConvertible]) throws {
// use `Self.javaClass` here
}
There was a problem hiding this comment.
i like the idea and i commited the changes. One thing, Self does not seem to be available here and i used type(of: self).javaClass to workaround it. Not really understanding why
Sources/JNI/JNIObjects.swift
Outdated
|
|
||
| private static var classInstances = [String: JavaClass]() | ||
|
|
||
| public class var javaClass: JavaClass { |
There was a problem hiding this comment.
This can be static now I think?
There was a problem hiding this comment.
yes, you are right
|
thanks for your help & guidance @ephemer |
|
@michael my pleasure! Thanks for putting this PR in |
No description provided.