API Enhancements #18
Merged
API Enhancements #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikner
force-pushed
the
api-enhancements
branch
from
77976f7 to
ffa9bf7
Compare
ephemer
approved these changes
Mar 12, 2021
| func GetField(_ fieldName: String, fieldJavaClassName: String, from javaObject: JavaObject) throws -> JavaObject { | ||
| let env = self._env | ||
| let javaClass = try GetObjectClass(obj: javaObject) | ||
| let fieldID = env.pointee.pointee.GetFieldID(env, javaClass, fieldName, "L\(fieldJavaClassName);") |
There was a problem hiding this comment.
I'm not sure but I think we might need to delete the local ref to the class here after we use it
There was a problem hiding this comment.
oh yes, totally oversaw this. we do it also in the other methods above :+1
| @@ -87,6 +87,10 @@ open class JNIObject { | |||
| return try jni.GetField(fieldName, from: self.instance) | |||
| } | |||
|
|
|||
| public func getField(_ fieldName: String, fieldJavaClassName: String) throws -> JavaObject { | |||
| return try jni.GetField(fieldName, fieldJavaClassName: fieldJavaClassName, from: self.instance) | |||
There was a problem hiding this comment.
Cool looks good, ideally we'd add getters for primitive fields too (Int etc) but we can also do that later when/if we need it
There was a problem hiding this comment.
I think what you mean is already covered by the generic methods above.
|
|
||
| func GetDirectBufferAddress(buffer: JavaObject) -> UnsafeMutableRawPointer? { | ||
| let env = self._env | ||
| return env.pointee.pointee.GetDirectBufferAddress(env, buffer) |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new public APIs: