Remove macOS #20
Merged
Remove macOS #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephemer
reviewed
Nov 5, 2024
.DS_Store
Outdated
There was a problem hiding this comment.
this file should be included in the .gitignore, preferably in your local global .gitignore 🙏🏼
ephemer
approved these changes
Nov 5, 2024
ephemer
reviewed
Nov 5, 2024
Sources/.DS_Store
Outdated
ephemer
reviewed
Nov 5, 2024
There was a problem hiding this comment.
this should also be removed, no? maybe not if it's added by Xcode's Swift PM support, but maybe we can avoid loading this package in Xcode at all if it's unneeded?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a macOS target which is now obsolete since the removal of the CJNI target.
That means we can cleanup the whole codebase from any xcodeproject files and macOS-related things.