[Feature]: GIF media support #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptoAlgorithm
force-pushed
the
gif
branch
3 times, most recently
from
d29761f to
faedef8
Compare
Pretty sure the commit summary isn’t grammatically correct to squeeze it into 80 characters
Allows custom width/height, different from image resolution, to be set Kind of a workaround currently, the NSViewRepresentable should automatically take dimensions from the .frame modifier in the future if possible. I haven’t found the combination of constraints that allow that though.
Also refactored size calculation to use Doubles
(in the future)
I am aware of a bug where the playback speed of the GIFs are faster than they should be, but this appears to be an unresolved bug in SwiftyGIF, rolling back as suggested in the issue doesn’t resolve it.
Animated user avatar is untested as I couldn’t find a user with one in a reasonable amount of time
The PR fixing a 120Hz refresh display hasn’t been merged yet, so I’ve changed the package dependency to my fork for the time being.
* Move attachment views to their own files * Move some functions in AttachmentView to an extension * Add some SwiftUI previews for certain types of attachments (they don’t work yet due to some Sparkle issue) Also updated ServerButtonStyle to use new extensions
cryptoAlgorithm
added a commit
that referenced
this pull request
Aug 3, 2022
This reverts commit 3504478.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds GIF 🎥 rendering support, a hotly-requested feature!
GIF Support:
gifvembeds, which aren't in the scope of this PR)