Skip to content
This repository was archived by the owner on Oct 28, 2024. It is now read-only.

Add sample project composer.json #199

Merged
merged 9 commits into from
May 29, 2021

Conversation

sypets
Copy link
Contributor

@sypets sypets commented Mar 18, 2021

Add an example composer.json file for a project to refer to.

@sypets sypets force-pushed the sypets/composer.json branch 3 times, most recently from dc5c260 to d127e5d Compare March 18, 2021 22:31
Add an example composer.json file for a project to refer to.
@sypets sypets force-pushed the sypets/composer.json branch from d127e5d to 59ce365 Compare March 18, 2021 22:36
Do not add this repository in the examples and point to information
about deprecation in the explanation.
@sypets sypets marked this pull request as draft March 19, 2021 09:00
@sypets
Copy link
Contributor Author

sypets commented Mar 19, 2021

@susannemoog I have asked for reviews on Slack in Composer channel. Please do not merge yet.

@linawolf
Copy link
Member

linawolf commented May 1, 2021

@sypets @susannemoog What is the status of this PR?

@sypets
Copy link
Contributor Author

sypets commented May 1, 2021

My recommendation would be to merge this. I think it is a good start but needs more work in the future.


To follow up here - I asked on Slack and some suggestions were:

Unfortunately noone supplied feedback content wise, which is a pity because I am sure there are people who know more about this than I do.

I was a little ambivalent about this, because there is always a downside to adding more information and more docs page. But I see this new docs page as a start page for everything concerning a project composer.json where we can aggregate all information and best practices and point to more information elsewhere.

@sypets sypets marked this pull request as ready for review May 1, 2021 09:32
@sypets sypets requested a review from mbrodala May 3, 2021 10:43
sypets added 4 commits May 4, 2021 12:03
A previous change resulted in extra semicolons, thus breaking the command.
This is now fixed.

All commands were concatenated with semicolon and baskslash.

Now all commands are given seperately, which makes it more readable.
The config should be before require.
@linawolf linawolf merged commit 73295a3 into TYPO3-Documentation:master May 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants