-
Notifications
You must be signed in to change notification settings - Fork 95
Add sample project composer.json #199
Add sample project composer.json #199
Conversation
dc5c260
to
d127e5d
Compare
Add an example composer.json file for a project to refer to.
d127e5d
to
59ce365
Compare
Do not add this repository in the examples and point to information about deprecation in the explanation.
@susannemoog I have asked for reviews on Slack in Composer channel. Please do not merge yet. |
@sypets @susannemoog What is the status of this PR? |
My recommendation would be to merge this. I think it is a good start but needs more work in the future. To follow up here - I asked on Slack and some suggestions were:
Unfortunately noone supplied feedback content wise, which is a pity because I am sure there are people who know more about this than I do. I was a little ambivalent about this, because there is always a downside to adding more information and more docs page. But I see this new docs page as a start page for everything concerning a project composer.json where we can aggregate all information and best practices and point to more information elsewhere. |
A previous change resulted in extra semicolons, thus breaking the command. This is now fixed. All commands were concatenated with semicolon and baskslash. Now all commands are given seperately, which makes it more readable.
The config should be before require.
Add an example composer.json file for a project to refer to.