Skip to content

feat(engine): Implement core object store functionality #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 56 commits into
base: main
Choose a base branch
from

Conversation

daryllimyt
Copy link
Contributor

@daryllimyt daryllimyt commented Apr 1, 2025

Motivation

  • Avoid returning large payloads from Temporal activities by storing them in Minio.

Todos

  • Additional testing matrix with different store configurations

Description

  • Phase 1: Roll out object store related functionality behind feature flag. Ensures that we remain fully backward compatible and tested
  • Phase 2: Complete additional object store features like presigned urls in the Ui for downloading large payloads, object expiration, conditional storage of payloads over a certain size threshold.
  • Phase 3: Security. TBH this is part of the matrix testing config. Just need to double check that we can use a non-root user account to r/w into minio

Copy link

zeropath-ai bot commented Apr 1, 2025

The following issues were found:

Reply to this PR with @zeropath-ai followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

1 similar comment
Copy link

zeropath-ai bot commented Apr 2, 2025

The following issues were found:

Reply to this PR with @zeropath-ai followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@daryllimyt daryllimyt added engine Improvements or additions to the workflow engine enhancement New feature or request performance Changes that improve performance labels Apr 2, 2025
@daryllimyt daryllimyt self-assigned this Apr 2, 2025
@daryllimyt daryllimyt requested a review from topher-lo April 2, 2025 10:28
Copy link

zeropath-ai bot commented Apr 2, 2025

The following issues were found:

Reply to this PR with @zeropath-ai followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

1 similar comment
Copy link

zeropath-ai bot commented Apr 2, 2025

The following issues were found:

Reply to this PR with @zeropath-ai followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@daryllimyt daryllimyt marked this pull request as ready for review April 2, 2025 13:07
@daryllimyt daryllimyt changed the title feat(engine): Implement basic object store feat(engine): Implement basic object store [1/N] Apr 2, 2025
@daryllimyt daryllimyt changed the title feat(engine): Implement basic object store [1/N] feat(engine): Implement object store [1/N] Apr 2, 2025
Copy link

zeropath-ai bot commented Apr 2, 2025

The following issues were found:

Reply to this PR with @zeropath-ai followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Copy link

zeropath-ai bot commented Apr 2, 2025

The following issues were found:

Reply to this PR with @zeropath-ai followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Copy link

zeropath-ai bot commented Apr 2, 2025

The following issues were found:

Reply to this PR with @zeropath-ai followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Copy link

zeropath-ai bot commented Apr 2, 2025

The following issues were found:

Reply to this PR with @zeropath-ai followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@daryllimyt daryllimyt changed the title feat(engine): Implement object store [1/N] feat(engine): Implement core object store functionality Apr 2, 2025
Copy link

zeropath-ai bot commented Apr 2, 2025

The following issues were found:

Reply to this PR with @zeropath-ai followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Copy link

zeropath-ai bot commented Apr 2, 2025

The following issues were found:

Reply to this PR with @zeropath-ai followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Copy link

zeropath-ai bot commented Apr 2, 2025

The following issues were found:

Reply to this PR with @zeropath-ai followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Copy link

zeropath-ai bot commented Apr 2, 2025

The following issues were found:

Reply to this PR with @zeropath-ai followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Copy link

zeropath-ai bot commented Apr 2, 2025

The following issues were found:

Reply to this PR with @zeropath-ai followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Copy link

zeropath-ai bot commented Apr 2, 2025

The following issues were found:

Reply to this PR with @zeropath-ai followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Copy link

zeropath-ai bot commented Apr 2, 2025

The following issues were found:

Reply to this PR with @zeropath-ai followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Copy link

zeropath-ai bot commented Apr 2, 2025

The following issues were found:

Reply to this PR with @zeropath-ai followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Copy link

zeropath-ai bot commented Apr 2, 2025

The following issues were found:

Reply to this PR with @zeropath-ai followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Copy link

zeropath-ai bot commented Apr 2, 2025

The following issues were found:

Reply to this PR with @zeropath-ai followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Copy link

zeropath-ai bot commented Apr 4, 2025

The following issues were found:

Reply to this PR with @zeropath-ai followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine Improvements or additions to the workflow engine enhancement New feature or request performance Changes that improve performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant