Skip to content

Implement some common meta headers #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

qstokkink
Copy link
Contributor

This should mostly fix Tribler/tribler#5577

  • Subresource Integrity (SRI) does not work with the Google tag script.
  • Initial redirection from HTTP to HTTPS is to a different host, preventing HSTS should be done in the DNS entry.

@qstokkink qstokkink merged commit 3d22cdb into Tribler:master Nov 14, 2024
@qstokkink qstokkink deleted the fix_easy_meta_tags branch November 14, 2024 10:47
@qstokkink
Copy link
Contributor Author

This upgraded us from a flat F to a C-: https://developer.mozilla.org/en-US/observatory/analyze?host=tribler.org

Some headers are apparently not allowed in the meta tags and they are seemingly ignored.

Comment on lines +8 to +10
<meta http-equiv="Content-Security-Policy" content="default-src 'self'; upgrade-insecure-requests">
<meta http-equiv="X-Content-Type-Options" content="nosniff">
<meta http-equiv="X-Frame-Options" content="SAMEORIGIN">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These three are not respected by my browser. I guess these are useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The security of our tribler.org website can be improved
2 participants