Showing repost and reply count on Profile

[vershwal]

Ref https://linear.app/ghost/issue/AP-864

[coderabbitai]

Walkthrough

The pull request involves modifications to the Profile.tsx file, specifically within the LikesTab component. The commentCount property of the FeedItem component has been updated by removing the previous assignment of activity.object.replyCount and reintroducing it in a different order within the component's props. Although the value assigned to commentCount remains unchanged, the adjustment affects the order of properties passed to the FeedItem component. No alterations to the declarations of exported or public entities were made in this diff.

Possibly related PRs

• Fixed replies not showing when viewing thread from profile #22408: This PR modifies the LikesTab component's commentCount property in Profile.tsx and is related to changes in the event handlers of the FeedItem component, particularly regarding the handling of the activity object.

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/admin-x-activitypub/src/views/Profile/Profile.tsx

Oops! Something went wrong! :(

ESLint: 8.44.0

ESLint couldn't find the plugin "eslint-plugin-react-hooks".

(The package "eslint-plugin-react-hooks" was not found when loaded as a Node module from the directory "/apps/admin-x-activitypub".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-react-hooks@latest --save-dev

The plugin "eslint-plugin-react-hooks" was referenced from the config file in "apps/admin-x-activitypub/.eslintrc.cjs".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 507bbe4 and 5fcf7e0.

📒 Files selected for processing (4)

• apps/admin-x-activitypub/src/views/Profile/Profile.tsx (5 hunks)
• apps/admin-x-activitypub/src/views/Profile/Profile.tsx (3 hunks)
• apps/admin-x-activitypub/src/views/Profile/Profile.tsx (1 hunks)
• apps/admin-x-activitypub/src/views/Profile/Profile.tsx (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• apps/admin-x-activitypub/src/views/Profile/Profile.tsx

🚧 Files skipped from review as they are similar to previous changes (3)

• apps/admin-x-activitypub/src/views/Profile/Profile.tsx
• apps/admin-x-activitypub/src/views/Profile/Profile.tsx
• apps/admin-x-activitypub/src/views/Profile/Profile.tsx

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

apps/admin-x-activitypub/src/views/Profile/Profile.tsx (1)

159-160: Display of comment and repost counts implemented.

Adding the commentCount and repostCount props to the FeedItem component successfully implements the requirement to show repost and reply counts on the Profile. The implementation correctly maps from the activity object's properties.

I notice that commentCount is mapped from activity.object.replyCount. If these are semantically different terms for the same concept, consider standardizing the naming in future refactoring.

Also applies to: 162-163

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 68c03cf and f2e5d19.

📒 Files selected for processing (1)

• apps/admin-x-activitypub/src/views/Profile/Profile.tsx (5 hunks)

🧰 Additional context used

🪛 GitHub Actions: CI

apps/admin-x-activitypub/src/views/Profile/Profile.tsx

[error] 16-16: Imports should be sorted alphabetically (ghost/sort-imports-es6-autofix/sort-imports-es6)

---

[error] 26-26: 'TData' is defined but never used (@typescript-eslint/no-unused-vars)

---

[error] 27-27: Unexpected any. Specify a different type (@typescript-eslint/no-explicit-any)

🔇 Additional comments (3)

apps/admin-x-activitypub/src/views/Profile/Profile.tsx (3)

7-7: Correct import added for the type changes.

The import for UseInfiniteQueryResult from @tanstack/react-query is necessary for the type changes in the hook interface.

---

49-51: Appropriate handling for posts data structure added.

This code correctly handles the new data structure where pages can contain 'posts', allowing the component to properly extract data from the useProfilePostsForUser hook.

---

129-130: Profile posts data hook implementation correctly updated.

The switch from useOutboxForUser to useProfilePostsForUser aligns with the requirements of showing repost and reply counts on the Profile view. This change ensures the appropriate data is fetched.