Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a couple of tests being removed from Turing.jl #840

Merged
merged 5 commits into from
Mar 17, 2025

Conversation

mhauru
Copy link
Member

@mhauru mhauru commented Mar 12, 2025

Contrast with the tests being removed in TuringLang/Turing.jl#2494

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.40%. Comparing base (4494438) to head (a71241e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #840   +/-   ##
=======================================
  Coverage   84.40%   84.40%           
=======================================
  Files          34       34           
  Lines        3840     3840           
=======================================
  Hits         3241     3241           
  Misses        599      599           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Mar 12, 2025

Benchmark Report for Commit fd38360366ad2adfeffeb99ac8a21d29701f31b3

Computer Information

Julia Version 1.11.4
Commit 8561cc3d68d (2025-03-10 11:36 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

|                 Model | Dimension |  AD Backend |      VarInfo Type | Linked | Eval Time / Ref Time | AD Time / Eval Time |
|-----------------------|-----------|-------------|-------------------|--------|----------------------|---------------------|
| Simple assume observe |         1 | forwarddiff |             typed |  false |                  9.3 |                 1.6 |
|           Smorgasbord |       201 | forwarddiff |             typed |  false |                597.1 |                41.2 |
|           Smorgasbord |       201 | forwarddiff | simple_namedtuple |   true |                350.8 |                50.8 |
|           Smorgasbord |       201 | forwarddiff |           untyped |   true |               1217.0 |                26.9 |
|           Smorgasbord |       201 | forwarddiff |       simple_dict |   true |               3663.1 |                21.3 |
|           Smorgasbord |       201 | reversediff |             typed |   true |               1450.8 |                29.1 |
|           Smorgasbord |       201 |    mooncake |             typed |   true |                929.8 |                 5.4 |
|    Loop univariate 1k |      1000 |    mooncake |             typed |   true |               5510.9 |                 5.0 |
|       Multivariate 1k |      1000 |    mooncake |             typed |   true |               1058.9 |                 8.4 |
|   Loop univariate 10k |     10000 |    mooncake |             typed |   true |              60996.7 |                 4.5 |
|      Multivariate 10k |     10000 |    mooncake |             typed |   true |               8702.8 |                 9.8 |
|               Dynamic |        10 |    mooncake |             typed |   true |                123.8 |                12.0 |
|              Submodel |         1 |    mooncake |             typed |   true |                 25.0 |                 7.5 |
|                   LDA |        12 | reversediff |             typed |   true |                463.3 |                 4.5 |

@coveralls
Copy link

coveralls commented Mar 12, 2025

Pull Request Test Coverage Report for Build 13901486926

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.489%

Totals Coverage Status
Change from base Build 13901447065: 0.0%
Covered Lines: 3241
Relevant Lines: 3836

💛 - Coveralls

Copy link
Member

@penelopeysm penelopeysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of trivial things, thanks for looking after these tests!

mhauru and others added 2 commits March 17, 2025 10:55
@mhauru mhauru requested a review from penelopeysm March 17, 2025 11:08
@penelopeysm penelopeysm enabled auto-merge March 17, 2025 13:48
@penelopeysm penelopeysm disabled auto-merge March 17, 2025 14:06
@penelopeysm penelopeysm enabled auto-merge March 17, 2025 14:06
@penelopeysm penelopeysm added this pull request to the merge queue Mar 17, 2025
Merged via the queue into main with commit d1a98c6 Mar 17, 2025
18 of 19 checks passed
@penelopeysm penelopeysm deleted the mhauru/dot-tilde-tests-from-turing branch March 17, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants