Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed using Flux: Tracker to using Flux.Tracker #584

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Conversation

cpfiffer
Copy link
Member

@cpfiffer cpfiffer commented Oct 9, 2018

This is possibly a pull request to fix #583, which appears to be a deprecation problem.

Currently we import Flux.Tracker like this:

using Flux: Tracker

When according to this it should be:

using Flux.Tracker

I wanted to open up a pull request here just to make sure I'm correct here. Thoughts?

@mohamed82008
Copy link
Member

This seems irrelevant to the linked Turing issue as warnings don't break compilation. Also the v0.7.0 warning for using A: B when B is a module seems to be a false threat as both work on Julia v1.0 and no breaking changes are happening in 1.x unless extremely necessary. But this seems like a harmless change to me, so I don't mind it.

@cpfiffer
Copy link
Member Author

cpfiffer commented Oct 9, 2018

It struck me as odd that I haven't seen this error on 1.0+. The patch notes seemed to indicate that this was a breaking change in 0.7.

@mohamed82008
Copy link
Member

They may have missed it 😝. Anyways, it's too late now to change it and 2.0 is quite far.

@mohamed82008 mohamed82008 merged commit c2f06a6 into master Oct 10, 2018
@cpfiffer cpfiffer deleted the csp/flux-bug branch April 20, 2019 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants