implement async task queue to synchronize react wrapper initialization useEffect #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This potentially uncovered different issue as it doesn't completely initialize the second time and it hangs at starting the language clients still looking into this |
|
superseded by #873 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #871
This will ensure that dispose is not invoked before the editor is fully started. This will slow down initialisation in development mode, as the editor will be fully started, then destroyed and started again; however, in production, it should work the same as in the main (unless some unexpected re-renders occur on the client side).
I have also added a regression test to verify the fix