create script using new Script #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
createScript is deprecated
1 similar comment
|
Sure, it's marked as deprecated since v0.12 but the old syntax was there to support v0.10. |
|
I'm not going to make this change for now as releasing this would mean releasing 2.0, which isn't really needed right now - the deprecated code, as far as I know, is not going away. When it does, we can revisit this. |
|
Looks like I'll merge and release this earlier than expected after #258 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createScript is mark deprecated on node.d.ts, and no documentation in (https://nodejs.org/dist/latest-v6.x/docs/api/vm.html).
All tests passed on Ubuntu 16.