Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regions names for parameterized tests #1301

Closed
alisevych opened this issue Nov 3, 2022 · 3 comments · Fixed by #1393
Closed

Regions names for parameterized tests #1301

alisevych opened this issue Nov 3, 2022 · 3 comments · Fixed by #1393
Assignees
Labels
comp-summaries Something related to the method names, code comments and display names generation ctg-bug Issue is a bug status-verified Bug fix is verified

Comments

@alisevych
Copy link
Member

alisevych commented Nov 3, 2022

Description

Some tests generated for ArraysQuickSort.sort in Parameterized mode are presented as regular tests.
They are put in to region
///region Tests for method sort(int[], int, int, int[], int, int) that cannot be presented as parameterized
Now there are 2 types of such tests:

To Reproduce

  1. Install latest build from main into IDEA 2022.2.3
  2. Check File -> Settings are default: 95% Symbolic execution
  3. Open UTBotJava project
  4. Generate tests for ArrayQuickSort with JUnit5 and Parameterized on.

Expected behavior

Regions in the generated tests are supposed to be similar to the ones generated with parameterization off.

Actual behavior

///region Tests for method sort(int[], int, int, int[], int, int) that cannot be presented as parameterized

Regions in generated tests, that cannot be presented as parameterized, do not contain information about which suite they belong to.
Fuzzing / Symbolic, Successful / Explicitly thrown exceptions / ...

Visual proofs (screenshots, logs, images)

Regions for parameterized tests:
image

Regions for regular tests:
image

Environment

IntelliJ IDEA

@alisevych alisevych added the ctg-bug Issue is a bug label Nov 3, 2022
@korifey korifey moved this to Todo in UTBot Java Nov 3, 2022
@alisevych
Copy link
Member Author

@korifey @amandelpie @EgorkaKulikov
Could you please check the expected and actual result? What would be the correct way to name these suites?

@alisevych alisevych added this to the 2022.12 Release milestone Nov 8, 2022
@alisevych alisevych added the comp-summaries Something related to the method names, code comments and display names generation label Nov 8, 2022
EgorkaKulikov added a commit that referenced this issue Nov 11, 2022
* Improve documentation for regions in parametrized tests
@amandelpie
Copy link
Collaborator

amandelpie commented Nov 14, 2022

@alisevych could we say now that we are satisfied for today with the existing master?

@alisevych
Copy link
Member Author

alisevych commented Nov 17, 2022

@alisevych could we say now that we are satisfied for today with the existing master?

As for regions for parameterized tests - they are readable:

    ///region Test suites for executable org.utbot.examples.algorithms.Sort.quickSort
    ///region Parameterized test for method quickSort(long[], int, int)
    ///endregion
    ///region FUZZER: Tests for method quickSort(long[], int, int)
    ///endregion
    ///endregion

Can we also leave information that these tests cannot be presented as parameterized - as it was done before?

EgorkaKulikov pushed a commit that referenced this issue Nov 18, 2022
Repository owner moved this from Todo to Done in UTBot Java Nov 18, 2022
@alisevych alisevych added the status-verified Bug fix is verified label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-summaries Something related to the method names, code comments and display names generation ctg-bug Issue is a bug status-verified Bug fix is verified
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants