Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We create temporary files a lot, we have to clean it either #1089

Merged
merged 4 commits into from
Oct 7, 2022
Merged

We create temporary files a lot, we have to clean it either #1089

merged 4 commits into from
Oct 7, 2022
+14 −9

Conversation

Vassiliy-Kudryashov
Copy link
Member

Description

New cleaning stage was added for files outside "UTBot" directory

Type of Change

  • Minor bug fix (non-breaking small changes)

How Has This Been Tested?

Manual Scenario

Check tempDir, it may contain a lot of small files named like:

  • Graph-vis***
  • {some digits}-0
  • byteBuddyAgent***.jar
  • mockitoboot***.jar
    We never clean it but we have to.

Checklist (remove irrelevant options):

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • No new warnings

Sorry, something went wrong.

@Vassiliy-Kudryashov Vassiliy-Kudryashov enabled auto-merge (squash) October 4, 2022 17:52
@Vassiliy-Kudryashov
Copy link
Member Author

Windows never automatically cleans the %TEMP% directory by default. In Windows 10 you have to enable this feature in Settings, and with earlier versions you must delete the files yourself or use programs like Disk Cleanup or cCleaner.

Vassiliy-Kudryashov and others added 2 commits October 6, 2022 13:36
@Vassiliy-Kudryashov
We create temporary files a lot, we have to clean it either
11ee557 
The fix: our own temp files are moved to UTBot subfolder where existing auto-cleaning does the job
@Vassiliy-Kudryashov
Merge branch 'main' into Vassiliy-Kudryashov/tmpDir_cleaning

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
e822dea
Damtev
Damtev approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@Damtev Damtev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vassiliy-Kudryashov Vassiliy-Kudryashov merged commit 31a2f7d into main Oct 7, 2022
@Vassiliy-Kudryashov Vassiliy-Kudryashov deleted the Vassiliy-Kudryashov/tmpDir_cleaning branch October 7, 2022 04:53
@alisevych alisevych added this to the 2022.10.1 Release milestone Oct 7, 2022
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull request Oct 17, 2022
@Vassiliy-Kudryashov @AbdullinAM
We create temporary files a lot, we have to clean it either (UnitTest…
58b4755 
…Bot#1089)
AbdullinAM pushed a commit to AbdullinAM/UTBotJava that referenced this pull request Oct 17, 2022
@Vassiliy-Kudryashov @AbdullinAM
We create temporary files a lot, we have to clean it either (UnitTest…
a215477 
…Bot#1089)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damtev Damtev

@Markoutte Markoutte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2022.10.1 Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Vassiliy-Kudryashov @Damtev @alisevych