Generated test output size should be customizable #1235 #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utbot-framework/src/main/kotlin/org/utbot/framework/codegen/model/util/CgPrinter.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/org/utbot/framework/codegen/model/constructor/tree/CgTestClassConstructor.kt
Outdated
Show resolved
Hide resolved
...src/main/kotlin/org/utbot/framework/codegen/model/constructor/tree/CgTestClassConstructor.kt
Show resolved
Hide resolved
After-review improvement
…ut-size-should-be-customizable
…ut-size-should-be-customizable
EgorkaKulikov
approved these changes
Nov 2, 2022
Vassiliy-Kudryashov
deleted the
Vassiliy-Kudryashov/1235-generated-test-output-size-should-be-customizable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two new settings were added: maxTestFileSize=1000000 and maxTestsPerMethod=50
Initially the issue was introduced by #1225 and you can reproduce 'bad' behavior with local reverting ea14197 or with patching of {HOME_DIR}/.utbot/settings.properties
In case number of executions for some method exceeds maxTestsPerMethod comment would be added in generated code.
In case file size exceeds maxTestFileSize no new tests methods would be added to the file, there should be message in log + notification in UI + the comment near ///endregion line
Fixes #1235
Type of Change
How Has This Been Tested?
Manual Scenario
Setup some small limits in {HOME_DIR}/.utbot/settings.properties and check generation output + UI behavior
Checklist (remove irrelevant options):