Fixed FileNotFoundExecption during JavaParser work #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1227 #1204
The main problem was the following: JavaParser tries to parse ZipEntry in zip archive with JDK sources.
ZipEntry is not a file.
To filter this situation, we decided to ignore these zipped sources from the standard library. In reality, we ignored it before @Domonion changes in the #1151 PR.
We extended our scope and failed when faced with these issues.
The proposed solution helps to avoid situation with parsing of non-existing files and also improves the logging for some edge situations.
Type of Change
How Has This Been Tested?
Manual Scenario
One of scenarios is described also in the ticket #1204
Checklist (remove irrelevant options):
This is the author self-check list