Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested classes & logs #1447

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Nested classes & logs #1447

merged 1 commit into from
Dec 2, 2022

Conversation

Domonion
Copy link
Collaborator

@Domonion Domonion commented Dec 1, 2022

Description

  1. fixes Missed source file for nested class #1359
  2. changes log formatting in IDEA process

Type of Change

Please delete options that are not relevant.

  • Minor bug fix (non-breaking small changes)
  • Bug fix (non-breaking change which fixes an issue)

Automated Testing

CI

@Domonion Domonion requested a review from amandelpie December 1, 2022 08:33
@Domonion Domonion force-pushed the kononov-nested-classes branch from 7933d1c to a64c2b4 Compare December 1, 2022 08:35
1. fixes #1359
2. changes log formatting in IDEA process
@Domonion Domonion force-pushed the kononov-nested-classes branch from a64c2b4 to 5ebd6dd Compare December 1, 2022 08:37
@Domonion Domonion enabled auto-merge (squash) December 1, 2022 09:13
@amandelpie
Copy link
Collaborator

Looks great, now it founds the source file for the nested class correctly

Copy link
Collaborator

@amandelpie amandelpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've debugged and tested for a few scenarios, the existing solution gives us ability to find the source file for the nested classes

@Domonion Domonion merged commit 7f92cb3 into main Dec 2, 2022
@Domonion Domonion deleted the kononov-nested-classes branch December 2, 2022 13:15
tamarinvs19 pushed a commit that referenced this pull request Dec 6, 2022
[rd & logs]
1. fixes #1359
2. changes log formatting in IDEA process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missed source file for nested class
2 participants