Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kryo race fix #1968

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Kryo race fix #1968

merged 1 commit into from
Mar 17, 2023

Conversation

Domonion
Copy link
Collaborator

@Domonion Domonion commented Mar 17, 2023 •
edited
Loading

  1. Fixing data race in inter-process communication: if multiple request accesses kryo when it writes message - kryo might increment some internal object graph fields in unpredictable order, causing serialized value become severely corrupted. This bug might be the reason for many other hard traceble bugs, for example Server.EngineProcessModel.generateTestReport is not bound to a protocol #1183
  2. minor refactoring and build fixes

FIx #1879

@Domonion
[utbot-interprocess]
01daff5 
1. fixing race in inter-process communication: if multiple request
   accesses kryo when it writes message - kryo might increment some
   internal object graph fields in unpredictable order, causing
   serialized value become severely corrupted. This bug might be the
   reason for many other hard traceble bugs.
2. minor refactoring and build fixes
@Domonion Domonion added comp-symbolic-engine Issue is related to the symbolic execution engine ctg-refactoring Issue related to refactoring process comp-summaries Something related to the method names, code comments and display names generation comp-rd Issue is related RD comp-instrumented-process Issue is related to Instrumented process labels Mar 17, 2023
@Domonion Domonion self-assigned this Mar 17, 2023
@Vassiliy-Kudryashov Vassiliy-Kudryashov merged commit 953dc8f into main Mar 17, 2023
@Vassiliy-Kudryashov Vassiliy-Kudryashov deleted the kononov-kryo-race-fix branch March 17, 2023 13:07
denis-fokin pushed a commit that referenced this pull request Mar 17, 2023
@Domonion @denis-fokin
Kryo race fix (#1968)
e6b1a59 
[utbot-interprocess]
1. fixing race in inter-process communication: if multiple request
   accesses kryo when it writes message - kryo might increment some
   internal object graph fields in unpredictable order, causing
   serialized value become severely corrupted. This bug might be the
   reason for many other hard traceble bugs.
2. minor refactoring and build fixes

(cherry picked from commit 953dc8f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vassiliy-Kudryashov Vassiliy-Kudryashov Vassiliy-Kudryashov approved these changes

Assignees

@Domonion Domonion

Labels
comp-instrumented-process Issue is related to Instrumented process comp-rd Issue is related RD comp-summaries Something related to the method names, code comments and display names generation comp-symbolic-engine Issue is related to the symbolic execution engine ctg-refactoring Issue related to refactoring process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UTBot generates several empty test classes when run for a pack of classes
2 participants
@Domonion @Vassiliy-Kudryashov