Implement new approach to create variables in parametrized tests #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgorkaKulikov
force-pushed
the
egor/parametrized_tests_variables
branch
3 times, most recently
from
82decc4 to
275697c
Compare
EgorkaKulikov
force-pushed
the
egor/parametrized_tests_variables
branch
from
275697c to
08928ee
Compare
ArsenHD
reviewed
Jul 20, 2022
utbot-framework-api/src/main/kotlin/org/utbot/framework/plugin/api/Api.kt
Outdated
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/framework/assemble/AssemblePrimitiveWrapper.kt
Show resolved
Hide resolved
...rk/src/main/kotlin/org/utbot/framework/codegen/model/constructor/tree/CgMethodConstructor.kt
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/framework/codegen/model/tree/CgElement.kt
Outdated
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/framework/codegen/model/tree/CgElement.kt
Outdated
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/framework/codegen/model/tree/CgElement.kt
Outdated
Show resolved
Hide resolved
EgorkaKulikov
force-pushed
the
egor/parametrized_tests_variables
branch
from
17cce95 to
dbbff7c
Compare
ArsenHD
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently parametrized test variables contains a lot of hacks in variable creation process.
For example,
expectedResultin method parameters and asserts is represented by to differentCgVariableinstancesAlso there is a strange hack with wrappers for
actualvariable.We need to remove all this ugly hacks.
Also some fixes in
deepEqualsmethod related to primitive wrappers are suggested.Fixes # (562)
Type of Change
How Has This Been Tested?
Automated Testing
utbot-samplesandContestEstimatorManual Scenario
Smoke regression testing of Codegen