Fix awt #883
Closed
Fix awt #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBOne-Kenobi
force-pushed
the
sbone/awt-fix
branch
4 times, most recently
from
ef88dfe to
0b84ee3
Compare
sergeypospelov
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
Looks nice. Except the styling, my only concern is about performance -- it would be good to measure and compare it to the previous approach. As I remember, there were some problems with Mockito's performance in some cases.
Also, what about having a document on mocking in the child process? What do we mock with Mockito and what we do by ourself and how we do it.
utbot-framework/src/main/kotlin/org/utbot/framework/concrete/InstrumentationContext.kt
Outdated
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/framework/concrete/MockUtil.kt
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/framework/concrete/MockValueConstructor.kt
Outdated
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/framework/concrete/MockValueConstructor.kt
Outdated
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/framework/concrete/MockValueConstructor.kt
Outdated
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/framework/concrete/MockValueConstructor.kt
Outdated
Show resolved
Hide resolved
utbot-framework/src/main/kotlin/org/utbot/framework/concrete/StaticMethodMockController.kt
Outdated
Show resolved
Hide resolved
|
Created a mega-issue on providing a documentation: #932 |
SBOne-Kenobi
force-pushed
the
sbone/awt-fix
branch
2 times, most recently
from
9cc67db to
515f289
Compare
sergeypospelov
force-pushed
the
sbone/awt-fix
branch
from
1a824ea to
aa38b08
Compare
SBOne-Kenobi
force-pushed
the
sbone/awt-fix
branch
3 times, most recently
from
a79f64c to
94a54e6
Compare
SBOne-Kenobi
force-pushed
the
sbone/awt-fix
branch
2 times, most recently
from
6ee6af7 to
a3ad120
Compare
SBOne-Kenobi
force-pushed
the
sbone/awt-fix
branch
from
a3ad120 to
3e68a25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our instrumentation can't mock static methods for system classes like
ImageIO.read(file). So I decided to rewrite mocking mechanism by using Mockito.Fixes #714
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Automated Testing
org.utbot.examples.mixed.ImageIOUsageTest
org.utbot.examples.mixed.LoggerExampleTest
org.utbot.examples.mock.*
Manual Scenario
Described in issue #714
Checklist: