Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI action is disabled for several selected classes or packages #882 #896

Conversation

Vassiliy-Kudryashov
Copy link
Member

Description

Better selection management was provided for the context

Fixes #882

Type of Change

Please delete options that are not relevant.

  • Minor bug fix (non-breaking small changes)

How Has This Been Tested?

Manual Scenario

See the issue

Checklist (remove irrelevant options):

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • No new warnings

@volivan239
Copy link
Collaborator

If multiple packages or .java-files are selected, classes from them are not included. Is this the expected behavior?

@volivan239
Copy link
Collaborator

volivan239 commented Sep 9, 2022

Seems weird that previously we used PsiElementHandler.containingClass but now we use com.intellij.psi.PsiElement.containingClass for the same purpose. If second one works correctly, shouldn't we delete containingClass from PsiElementHandler (maybe in another PR)?

Copy link
Collaborator

@volivan239 volivan239 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for me with the latest changes!

@Vassiliy-Kudryashov Vassiliy-Kudryashov merged commit 40d1215 into main Sep 12, 2022
@Vassiliy-Kudryashov Vassiliy-Kudryashov deleted the Vassiliy-Kudryashov/882-ui-action-is-disabled-for-several-selected-classes-or-packages branch September 12, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI action is disabled for several selected classes or packages
2 participants