Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure update #164

Merged
merged 5 commits into from
Sep 5, 2023
Merged

Infrastructure update #164

merged 5 commits into from
Sep 5, 2023

Conversation

Lipen
Copy link
Member

@Lipen Lipen commented Sep 4, 2023

The PR adds the centralized buildSrc-based dependency management and slightly cleanups/reorganizes build scripts.

There are multiple places where I am not completely sure what to do:

  • soot_utbot_fork is probably from a private repo, so I haven't inserted any link to github in buildSrc/Dependencies.kt list, and simply used the already specified artifact group/id.
  • Jooq setup is not very well documented for modern-style Gradle/Kotlin projects, so I've just left the existing buildscript { ...classpath... } setup as it is (in jacodb-core).
  • There are multiple places where tests search for the specific versions of deps in the classpath, e.g. classpath.first { it.contains("guava-31.1-jre.jar") }, which I've changed to just it.contains("guava-"), since this dep might be bumped in the future.
  • I've retained most of dependency versions without updating to the latest ones. Mostly because the project does not compile or some tests fail when I'm doing an upgrade. For example, the project does not compile with the latest Gradle (8.3), so I've used the old 7.6.1 version of it. In addition, some KotlinNullabilityTests are failing on Kotlin 1.9.10 (it seems, JacoDB cannot properly find the parameter names anymore), so I've retained Kotlin 1.7.21 version.

Note that we probably want to first merge #155 and #163, and then update this PR.

@Lipen Lipen requested a review from lehvolk September 4, 2023 08:47
@lehvolk
Copy link
Collaborator

lehvolk commented Sep 5, 2023

soot_utbot_fork is probably from a private repo, so I haven't inserted any link to github in buildSrc/Dependencies.kt list, and simply used the already specified artifact group/id.

Here it goes: https://github.com/UnitTestBot/soot It's deployed to maven central.

There are multiple places where tests search for the specific versions of deps in the classpath, e.g. classpath.first { it.contains("guava-31.1-jre.jar") }, which I've changed to just it.contains("guava-"), since this dep might be bumped in the future.

Ok. Seems legit.

I've retained most of dependency versions without updating to the latest ones. Mostly because the project does not compile or some tests fail when I'm doing an upgrade. For example, the project does not compile with the latest Gradle (8.3), so I've used the old 7.6.1 version of it. In addition, some KotlinNullabilityTests are failing on Kotlin 1.9.10 (it seems, JacoDB cannot properly find the parameter names anymore), so I've retained Kotlin 1.7.21 version.

Let's update Gradle and Kotlin version in a scope of another PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Test results on JDK 8

1 030 tests  ±0   1 019 ✔️ ±0   7m 39s ⏱️ -26s
     43 suites ±0        11 💤 ±0 
     43 files   ±0          0 ±0 

Results for commit daad12d. ± Comparison against base commit 89d185c.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #164 (daad12d) into develop (89d185c) will increase coverage by 0.02%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop     #164      +/-   ##
=============================================
+ Coverage      76.41%   76.44%   +0.02%     
- Complexity      1482     1485       +3     
=============================================
  Files            154      154              
  Lines           8452     8452              
  Branches        1434     1434              
=============================================
+ Hits            6459     6461       +2     
  Misses          1446     1446              
+ Partials         547      545       -2     

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Test results on JDK 19

1 030 tests  ±0   1 019 ✔️ ±0   9m 11s ⏱️ - 1m 30s
     43 suites ±0        11 💤 ±0 
     43 files   ±0          0 ±0 

Results for commit daad12d. ± Comparison against base commit 89d185c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Test results on JDK 11

1 030 tests  ±0   1 022 ✔️ ±0   10m 16s ⏱️ -24s
     43 suites ±0          8 💤 ±0 
     43 files   ±0          0 ±0 

Results for commit daad12d. ± Comparison against base commit 89d185c.

♻️ This comment has been updated with latest results.

@lehvolk lehvolk merged commit 2203941 into develop Sep 5, 2023
@lehvolk lehvolk deleted the lipen/infra branch September 5, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants