Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct access modifier #4440

Closed
wants to merge 1 commit into from
Closed

Correct access modifier #4440

wants to merge 1 commit into from

Conversation

jimrogerz
Copy link

Proposed change(s)

Correcting the access modifier for SideChannel.OnMessageReceived.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

https://docs.unity3d.com/Packages/[email protected]/api/Unity.MLAgents.SideChannels.SideChannel.html

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • [x ] Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@chriselion
Copy link
Contributor

@jimrogerz can you sign the CLA so that we can merge this?

@chriselion
Copy link
Contributor

@chriselion
Copy link
Contributor

I rolled this change into #4466, which also fixes the python example code.

@chriselion chriselion closed this Sep 9, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants