Unity Build Cleanup #128
Merged
Unity Build Cleanup #128
+1,506
−516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnityAlex
force-pushed
the
build-cleanup
branch
from
95a3eb8 to
7a5b79b
Compare
mrvoorhe
reviewed
Mar 15, 2023
UnityAlex
force-pushed
the
build-cleanup
branch
2 times, most recently
from
f61c8c8 to
431a211
Compare
Use local 7z when not running on yamato
UnityAlex
force-pushed
the
build-cleanup
branch
from
431a211 to
6b95dfb
Compare
Need to pass special flag to ensure our args are only passed to the build script.
UnityAlex
force-pushed
the
build-cleanup
branch
from
45de630 to
793af89
Compare
UnityAlex
force-pushed
the
build-cleanup
branch
3 times, most recently
from
8daaa9e to
727524a
Compare
mrvoorhe
reviewed
Mar 17, 2023
mrvoorhe
reviewed
Mar 17, 2023
mrvoorhe
reviewed
Mar 17, 2023
mrvoorhe
reviewed
Mar 17, 2023
mrvoorhe
reviewed
Mar 17, 2023
mrvoorhe
reviewed
Mar 17, 2023
mrvoorhe
approved these changes
Mar 17, 2023
Removing / updating TODO's after investigation.
UnityAlex
force-pushed
the
build-cleanup
branch
from
727524a to
d2935a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will remove the need for the following scrips:
.yamato/scripts/test_linux.sh.yamato/scripts/test_osx.sh.yamato/scripts/test_windows.cmd.yamato/scripts/build_linux.sh.yamato/scripts/build_osx.sh.yamato/scripts/build_windows.cmdThey are replaced with:
.yamato/scripts/build_yamato.cmd.yamato/scripts/build_yamato.shAll of the build logic has been moved into
unity/CITools/BuildDriverto have a single source of truth.