Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility issue: ambiguous link text in settings modal #1074

Closed
scoutb-cogapp opened this issue Aug 12, 2024 · 6 comments
Closed

Accessibility issue: ambiguous link text in settings modal #1074

scoutb-cogapp opened this issue Aug 12, 2024 · 6 comments

Comments

@scoutb-cogapp
Copy link

UV version: [email protected]

I'm submitting a: bug report => please fork one of these codesandbox examples with a repro of your issue and include a link to it below

Page area

more info link inside settings modal

Issue description

There is a link at the bottom of the settings modal to the UV github page. The visible label is "more info" and this is what a screenreader will read out. It is impossible to tell what this more info is and where the link leads: neither link text nor context give a hint. Even a user actually looking for a link to UV or their repo may miss this link.

This is actually an issue for ALL users but users who are not navigating by mouse much more so, because mouse user can hover over the mysterious link and see the web address displayed (in most browsers).
A screenreader or keyboard user will have to use complicated workarounds to find out where this link leads (proably easiest to just click on it).

Steps to reproduce

  1. open this manifest
  2. Activate to the settings modal
  3. Find the link to the github repo

Expected behaviour

Link text should be more descriptive, for example "more info about Universal Viewer".

Possible fix

Change the visible link text.
Note that just adding an accessible label without changing the visible text would not fix this issue for everyone, and may even introduce other problems (accessible labels must contain the visible label, see WCAG Criterion 2.5.3 Label in Name)

WCAG criterion

2.4.4 Link Purpose (In Context) (Level A)

Related code

<a href="https://github.com/universalviewer/universalviewer" target="_blank">more info</a>

Other information

Note: Although there is an exception in the rule stating this behaviour is acceptable in instances where the link text is ambiguous to all users (not just disabled), I would not apply the exception here because the link is surely not meant to be ambiguous and also because the workaround for sighted users is so much easier and quicker than screenreader users.
And most of all: Fixing the link text will make UV better for everyone.

@demiankatz demiankatz moved this to To be assessed in Universal Viewer Community Board Aug 12, 2024
@scoutb-cogapp scoutb-cogapp changed the title Accessibility bug: ambiguous link text in settings modal Accessibility issue: ambiguous link text in settings modal Aug 13, 2024
@LlGC-szw LlGC-szw moved this from Accessibility Backlog to Community Sprint in Universal Viewer Community Board Oct 15, 2024
@Geoffsc
Copy link
Contributor

Geoffsc commented Oct 16, 2024

I would be happy to take this one, thanks

Geoffsc added a commit to Geoffsc/universalviewer that referenced this issue Oct 16, 2024
Geoffsc pushed a commit to Geoffsc/universalviewer that referenced this issue Oct 16, 2024
@Geoffsc
Copy link
Contributor

Geoffsc commented Oct 17, 2024

@LlGC-szw I need translations for the following string to add to my PR:
"More info about the Universal Viewer"

@LlGC-szw
Copy link

More info about the Universal Viewer = Mwy o wybodaeth am y Universal Viewer

@demiankatz
Copy link
Contributor

More info about the Universal Viewer = Mwy o wybodaeth am y Universal Viewer

Thanks, @LlGC-szw! Do we have a process for obtaining the other three translations (French, Polish and Swedish)?

@LlGC-szw
Copy link

We don't so I'll ask on the general forum if there's anyone who could contribute translations for those languages.

@erinburnand
Copy link

French - En savoir + sur le Universal Viewer (apparently the + is used as plus, or more, in French)

Polish - więcej informacji o Universal Viewer

@github-project-automation github-project-automation bot moved this from Community Sprint IN PROGRESS to Completed in Universal Viewer Community Board Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Community Sprint COMPLETED
Development

No branches or pull requests

5 participants