Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate all remaining divs with .label and replace with label (search for class="label") #1103

Closed
Tracked by #775
LlGC-szw opened this issue Sep 5, 2024 · 2 comments
Closed
Tracked by #775

Eliminate all remaining divs with .label and replace with label (search for class="label") #1103

LlGC-szw opened this issue Sep 5, 2024 · 2 comments
Assignees
@msimpsonBL
Labels
accessibility accessibility-markup

Comments

@LlGC-szw
Copy link

LlGC-szw commented Sep 5, 2024

No description provided.

@LlGC-szw LlGC-szw moved this to Accessibility Backlog in Universal Viewer Community Board Sep 5, 2024
@jamesmisson jamesmisson self-assigned this Oct 16, 2024
@msimpsonBL
Copy link
Contributor

I'm happy to pick this one up. Just to confirm it is replacing all div elements with the class label with the label element itself?

@demiankatz
Copy link
Contributor

I'm happy to pick this one up. Just to confirm it is replacing all div elements with the class label with the label element itself?

Yes, that is my understanding of the task -- and, of course, making sure that this change doesn't visually break anything.

msimpsonBL added a commit to msimpsonBL/universalviewer that referenced this issue Oct 21, 2024
@msimpsonBL
Replaced divs with label class with label element (fixes UniversalVie…
cc05761 
…wer#1103)
@msimpsonBL msimpsonBL mentioned this issue Oct 21, 2024
Merged
demiankatz pushed a commit that referenced this issue Oct 21, 2024
@msimpsonBL
Replaced divs with label class with label element (fixes #1103) (#1152)
b74120a
@github-project-automation github-project-automation bot moved this from Community Sprint IN TESTING to Completed in Universal Viewer Community Board Oct 21, 2024
@LlGC-szw LlGC-szw mentioned this issue Oct 21, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msimpsonBL msimpsonBL

Labels
accessibility accessibility-markup
Projects
Universal Viewer Community Board
Status: Community Sprint COMPLETED
Milestone
No milestone
Development

No branches or pull requests
4 participants
@demiankatz @LlGC-szw @jamesmisson @msimpsonBL