Upgrading to Openseadragon v4 #905
Conversation
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Thanks, @404mike -- I noticed that build is failing here -- I think the comment below explains why. Let me know if I can do more to help!
|
@404mike Could report on progress on this please? |
Bumps [ws](https://github.com/websockets/ws) from 5.2.3 to 5.2.4. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@5.2.3...5.2.4) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…ot/npm_and_yarn/ws-5.2.4 Bump ws from 5.2.3 to 5.2.4
|
Thanks, @404mike. Next questions: 1.) I see that there are some newer openseadragon versions available now -- 4.1.1 and 5.0.0 being possible candidates for a next step forward. Do we want to merge this first as an incremental step, or should we try out the newer releases? 2.) Assuming we want to stick with the version that's chosen here, would you like some help testing this? I imagine it would be a good idea to carefully put OSD through its paces to be sure nothing has broken, given the large version jump here. |
|
@demiankatz v4 seems fine. v5 doesn't work quite right. It throws an error |
|
@404mike, I noticed that this was targeted against the main branch but needed to be updated to target dev instead. I've made the necessary adjustments so it can end up in the correct location. |
There was a problem hiding this comment.
This looks good to me so far, but I'd appreciate if @LanieOkorodudu or others could also take a look!
|
I've also gone ahead and bumped this to 4.1.1 so we're on the latest 4.x release; it seems to work just as well as 4.0.0. |
Looks good for me too @demiankatz |
|
Thank you @demiankatz @LanieOkorodudu |
|
Thanks, everyone -- merging now! |
Upgrade openseadragon dependancy to version
4.0.0. Current version2.4.2containsevalfunction in production release. Openseadragon has removed this code in its latest release.