Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace @unly/utils-simple-logger and winston by @unly/simple-logger and chalk (reduces bundle size by 40Kb) #314

Merged
merged 7 commits into from
May 8, 2021

Conversation

Vadorequest
Copy link
Member

@Vadorequest Vadorequest commented May 8, 2021

This replaces the @unly/utils-simple-logger by a new @unly/simple-logger package.

The winston dependency has been removed, and been replaced by chalk (8kb gzipped) which is only being imported on the server.

The new package is <1Kb on the browser.

image

@github-actions github-actions bot had a problem deploying to customer1-staging May 8, 2021 18:09 Failure
@Vadorequest Vadorequest changed the title Remove @unly/utils-simple-logger and winston + replace by @unly/simple-logger Replace @unly/utils-simple-logger and winston by @unly/simple-logger and chalk (reduces bundle size by 40Kb) May 8, 2021
@github-actions
Copy link

github-actions bot commented May 8, 2021

❌  Deployment FAILED
Commit 39385f1 failed to deploy to
click to see logs

@github-actions
Copy link

github-actions bot commented May 8, 2021

✅  Deployment SUCCESS
Commit 39385f1 successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-at-lcz-sty-storybook-ki08viij3-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-storybook

@github-actions
Copy link

github-actions bot commented May 8, 2021

✅  E2E tests SUCCESS for commit 39385f1 previously deployed Storybook static site at https://nrn-v2-mst-aptd-at-lcz-sty-storybook-ki08viij3-unly-oss.vercel.app

@github-actions github-actions bot temporarily deployed to customer1-staging May 8, 2021 21:00 Inactive
@github-actions github-actions bot temporarily deployed to storybook May 8, 2021 21:00 Inactive
@github-actions
Copy link

github-actions bot commented May 8, 2021

✅  Deployment SUCCESS
Commit 0dbfa1b successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-9oboeul1p-unly-oss.vercel.app
Deployment aliased as

@github-actions
Copy link

github-actions bot commented May 8, 2021

✅  Deployment SUCCESS
Commit 0dbfa1b successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-at-lcz-sty-storybook-d298w61sm-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-storybook

@github-actions
Copy link

github-actions bot commented May 8, 2021

✅  E2E tests SUCCESS for commit 0dbfa1b previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-9oboeul1p-unly-oss.vercel.app

@github-actions
Copy link

github-actions bot commented May 8, 2021

✅  E2E tests SUCCESS for commit 0dbfa1b previously deployed Storybook static site at https://nrn-v2-mst-aptd-at-lcz-sty-storybook-d298w61sm-unly-oss.vercel.app

@Vadorequest Vadorequest marked this pull request as ready for review May 8, 2021 21:13
@github-actions github-actions bot temporarily deployed to storybook May 8, 2021 21:14 Inactive
@github-actions github-actions bot temporarily deployed to customer1-staging May 8, 2021 21:14 Inactive
@github-actions
Copy link

github-actions bot commented May 8, 2021

✅  Deployment SUCCESS
Commit 0c411b9 successfully deployed Next.js app 🚀 to https://nrn-v2-mst-aptd-at-lcz-sty-c1-v669ipe0w-unly-oss.vercel.app
Deployment aliased as

@github-actions
Copy link

github-actions bot commented May 8, 2021

✅  Deployment SUCCESS
Commit 0c411b9 successfully deployed Storybook static site 📖 to https://nrn-v2-mst-aptd-at-lcz-sty-storybook-72naeykb9-unly-oss.vercel.app
Deployment aliased as nrn-v2-mst-aptd-at-lcz-sty-storybook

@github-actions
Copy link

github-actions bot commented May 8, 2021

✅  E2E tests SUCCESS for commit 0c411b9 previously deployed at https://nrn-v2-mst-aptd-at-lcz-sty-c1-v669ipe0w-unly-oss.vercel.app

@github-actions
Copy link

github-actions bot commented May 8, 2021

✅  E2E tests SUCCESS for commit 0c411b9 previously deployed Storybook static site at https://nrn-v2-mst-aptd-at-lcz-sty-storybook-72naeykb9-unly-oss.vercel.app

@Vadorequest Vadorequest merged commit cf995a1 into v2-mst-aptd-at-lcz-sty May 8, 2021
@Vadorequest Vadorequest deleted the replace-utils-simple-logger branch May 8, 2021 21:42
Vadorequest added a commit that referenced this pull request May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant