UI components and pages #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oculux314
reviewed
Apr 22, 2025
There was a problem hiding this comment.
Great work Ashton, I love the attention to architecture and shadcn is a great decision
What's your thoughts with the index.ts files? It's a good idea but I wanna firm it up before others begin using/modifying it since some ui folders use the index.ts and others don't
Also, could I get you to just move those public images to an assets folder? Public folder is evil and we shouldn't use it unless we have to ;)
| import { useSWRWithZod } from "@/utils/swr"; | ||
|
|
||
| export default function useChallengeQuery(id: number) { | ||
| // i don't think you're suppose to use the key like this, someone lmk |
There was a problem hiding this comment.
Nah seems legit (why time tho 👀)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
might cause merge conflict oops,
/boardand/collectpageHow To Review
/uifor components/app/boardfor shadcn integration, game board and mock data calling/app/collectfancy three jsNotes