Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loaded event does not fire on fallback #25

Closed
victor-ca opened this issue Feb 27, 2018 · 0 comments
Closed

loaded event does not fire on fallback #25

victor-ca opened this issue Feb 27, 2018 · 0 comments
Milestone
1.3.3

Comments

@victor-ca
Copy link

victor-ca commented Feb 27, 2018 •
edited
Loading

  1. use bad image and valid placeholder, ex
 <img src="not-working-image" alt="not working image with working fallback" [src-fallback]="workingPlaceholder" (loaded)="onLoad($event)">
  1. Wait until the placeholder loads

Expected
onLoad to be called with true
Actual
onLoad not called
victor-ca pushed a commit to victor-ca/ngx-img-fallback that referenced this issue Feb 27, 2018
VadimDez#25 onLoad to be called when the fallback image is used
fa2df21
victor-ca pushed a commit to victor-ca/ngx-img-fallback that referenced this issue Feb 27, 2018
VadimDez#25 onLoad to be called when the fallback image is used
4aa6419
@victor-ca victor-ca mentioned this issue Feb 27, 2018
Merged
VadimDez added a commit that referenced this issue Feb 27, 2018
@VadimDez
Merge pull request #26 from victor-ca/master
c2b362d 
#25 onLoad to be called when the fallback image is used
@VadimDez VadimDez added this to the 1.3.3 milestone Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.3
Development

No branches or pull requests
2 participants
@VadimDez @victor-ca