Fix assigning Flowing Water (regression from 6b00a3430d080ecf0b47ed0e13b... #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when rendering WITH water (-nowater not set) the assignBlock water case did not hit and ended in the default else tree, which was only supposed to happen for doublesteps. Flowing water has a "col" value, depending on its height, we did hit the sandstone & wood & cobblestone doublestep case, which is why only height flowing water was replaced and the "low" flowing water not.
WRIM
added a commit
that referenced
this pull request
Jul 22, 2015
Fix assigning Flowing Water (regression from 6b00a34...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...e535b7f2d5eef)
when rendering WITH water (-nowater not set) the assignBlock water case did not hit
and ended in the default else tree, which was only supposed to happen for doublesteps.
Flowing water has a "col" value, depending on its height, so we did hit the
sandstone & wood & cobblestone doublestep case, which is why only height(col 1&2&3) flowing water
was replaced and the "low" flowing water not.
NOTE: also tested -nowater, still works
Images show the bug (without patch)