Create individual Scanner and Review image controller #213

chawatvish · 2020-01-29T02:53:57Z

I make the new one from your code to the individual scanner and review the image controller. People can use it easier and they can custom control UI.

Thanks for the review and feel free for any questions or comments on my code.

… view controller.

…iew controller.

Master

…velop # Conflicts: # WeScan.xcodeproj/project.pbxproj

AvdLee

First of all, thanks for your contribution! This starts to look good. @Boris-Em I would love to have your perspective as well as this is quite a big code change.

WeScan/Edit/EditImageViewController.swift

WeScan/Edit/EditScanViewController.swift

WeScanSampleProject/HomeViewController.swift

WeScanSampleProject/ImplementEditImageViewController.swift

WeScanSampleProject/ImplementNewCameraViewController.swift

WeScanSampleProject/ImplementReviewImageViewController.swift

… to 'a new scan'

Boris-Em

Thank you for your contribution @chawatvish!
I like the idea of this PR. I have a few high level comments we should address.

WeScan/Edit/EditImageViewController.swift

WeScanSampleProject/EditImageViewController.swift

ghost · 2020-03-03T13:16:26Z

	Warnings
⚠️	Capabilities for Signing & Capabilities may not function correctly because its entitlements use a placeholder team ID. To resolve this, select a development team in the WeScanSampleProject editor. (in target 'WeScanSampleProject' from project 'WeScan')

	Messages
📖	View more details on Bitrise
📖	WeScan: Executed 56 tests, with 0 failures (0 unexpected) in 20.018 (20.153) seconds

WeScanSampleProject.app: Coverage: 32.2

File	Coverage
EditImageViewController.swift	0.0%	⚠️
ReviewImageViewController.swift	0.0%	⚠️
NewCameraViewController.swift	0.0%	⚠️
HomeViewController.swift	43.15%	✅

WeScan.framework: Coverage: 36.48

File	Coverage
EditScanViewController.swift	0.0%	⚠️
EditScanCornerView.swift	84.09%	✅
FocusRectangleView.swift	90.32%	✅
QuadrilateralView.swift	68.28%	✅
CameraScannerViewController.swift	0.0%	⚠️
EditImageViewController.swift	0.0%	⚠️

Generated by 🚫 Danger Swift against 74a3471

AvdLee · 2020-03-04T09:12:28Z

On our controllers, can I add open of these classes for creating unit tests of a project that would like to use our library?

@chawatvish you can use @testable import WeScan to make internal viewcontrollers available. We like to keep them public if possible.

chawatvish · 2020-03-05T06:19:49Z

On our controllers, can I add open of these classes for creating unit tests of a project that would like to use our library?

@chawatvish you can use @testable import WeScan to make internal viewcontrollers available. We like to keep them public if possible.

I will try. Thank you 🙏🏻

# Conflicts: # WeScan.xcodeproj/project.pbxproj

chawatvish · 2020-03-23T04:18:00Z

Can you review and approve my merge request? @Boris-Em

alokc83 · 2020-04-14T22:04:17Z

Hey Guy, I just discovered your library today. It's so amazing and easy to work with.
@chawatvish work is amazing. Is there a chance that this PR get a merge quicker. I would love to try out the Custom UI that Chawatvish added.

chawatvish · 2020-04-15T06:55:18Z

Hey Guy, I just discovered your library today. It's so amazing and easy to work with.
@chawatvish work is amazing. Is there a chance that this PR get a merge quicker. I would love to try out the Custom UI that Chawatvish added.

Thank a lot. I waiting for @Boris-Em approve my PR.

Merge new WeScan master

Boris-Em

Apologies for the late reply.
The code looks good @chawatvish, but I struggle a bit to really understand what's happening on this PR.
Could you elaborate a bit more about how the new classes you're introducing are supposed to be used for example? What is the end goal of this PR from a user perspective?

Boris-Em · 2020-04-20T10:34:19Z

WeScan/Edit/EditImageViewController.swift

+import UIKit
+import AVFoundation
+
+/// A method that your delegate object must implement to get cropped image.


This is the documentation for the function, but it is on the protocol.
We need to have documentation for both.

Hi @Boris-Em
Apologies for the late reply.

This PR I would like to split the camera and edit image view out of other components.
I think we should have an individual view of a capture object and edit images after capture.
About other components like flash button, auto/manual detect, or shutter button people can customize it.

This is the documentation for the function, but it is on the protocol.
We need to have documentation for both.

Means I have to document on code right?

Yes, on the function (line 14).

I changed it las 2 days. Thank you 🙏🏻

Did you review it?

github-actions · 2020-05-21T00:07:33Z

This PR is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days.

Merge wescan master to master

Update cancel button title. wescan.edit.button.cancel is not found in…

chawatvish · 2020-06-20T06:32:05Z

@Boris-Em Any comment else?

AvdLee · 2020-07-06T11:49:17Z

@Boris-Em please revisit this once you're back from your holiday! 💪

Merge origin master to master

Boris-Em

I'm back!
Thanks for the hard work @chawatvish.

ghost · 2020-07-22T12:11:25Z

Congratulations! 🎉 This was released as part of Release 1.7.0 🚀

Generated by GitBuddy

Chawatvish Worrapoj and others added 12 commits January 6, 2020 18:05

Changed new camera scanner view controller.

ee2d89d

Try implement new camera scanner.

ea9070a

Added new edit image view controller.

52f665b

Added crop function and delegate to send image back to subscription v…

bbb6640

…iew controller.

Fixed no delegate var.

f9b88c9

Added example implement of edit and review image.

8801cc2

Changed bundle id back to We transfer.

e356643

Roll back info.plist

2e30768

Merge branch 'develop' into develop

e691d53

Merge pull request #1 from WeTransfer/master

2499d8b

Master

Merge branch 'master' of https://github.com/chawatvish/WeScan into de…

78c0a62

…velop # Conflicts: # WeScan.xcodeproj/project.pbxproj

chawatvish requested review from AvdLee and Boris-Em as code owners January 29, 2020 02:53

Merge develop to master

92d9907

AvdLee suggested changes Jan 30, 2020

View reviewed changes

chawatvish and others added 12 commits January 30, 2020 23:12

Rollback to final class

cba6ed4

Removed optional image param of delegate function.

645e7bb

Fixed method doesn't conform protocol.

f4f2d33

Fixed syntax follow SwiftLint rules.

ef394da

Fixed syntax follow SwiftLint rules.

f420570

Renamed of sample project files. Changed button title name from 'new'…

8d40aaa

… to 'a new scan'

Removed file out.

4592480

Fixed syntax follow SwiftLint rules.

a3fe8a3

update sub project comit.

e529f8e

Merge branch 'master' of https://github.com/WeTransfer/WeScan

9643a39

Merge from wetranfer:master

bce8185

Added rotate function on edit image view.

04e7e3c

Boris-Em suggested changes Feb 4, 2020

View reviewed changes

WeScan/Edit/EditImageViewController.swift Show resolved Hide resolved

WeScanSampleProject/EditImageViewController.swift Outdated Show resolved Hide resolved

WeScanSampleProject/EditImageViewController.swift Outdated Show resolved Hide resolved

Fixed detail of files.

d1af460

AvdLee approved these changes Mar 4, 2020

View reviewed changes

Added final class instead.

f7b8656

chawatvish requested a review from a user March 6, 2020 00:48

chawatvish added 2 commits March 11, 2020 21:16

update CI

bc4ee02

Merge branch 'master' of https://github.com/WeTransfer/WeScan

219beaf

# Conflicts: # WeScan.xcodeproj/project.pbxproj

chawatvish and others added 3 commits April 15, 2020 14:00

Merge pull request #5 from WeTransfer/master

5d8af4f

Merge new WeScan master

Added can setup auto scan from outside.

c02d8fa

Use toggle function instead

0498de7

chawatvish requested a review from a user April 15, 2020 17:06

Boris-Em suggested changes Apr 20, 2020

View reviewed changes

github-actions bot added the Stale label May 21, 2020

Merge pull request #6 from WeTransfer/master

585fff6

Merge wescan master to master

chawatvish requested a review from Boris-Em May 25, 2020 04:25

Chawatvish Worrapoj and others added 2 commits May 29, 2020 21:46

Fixed comment of public edit image view protocol.

e08ee8b

Merge pull request #7 from WeTransfer/master

7cdee68

Update cancel button title. wescan.edit.button.cancel is not found in…

github-actions bot closed this Jul 1, 2020

AvdLee reopened this Jul 6, 2020

Merge pull request #8 from WeTransfer/master

74a3471

Merge origin master to master

Boris-Em approved these changes Jul 20, 2020

View reviewed changes

AvdLee merged commit a265d33 into WeTransfer:master Jul 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create individual Scanner and Review image controller #213

Create individual Scanner and Review image controller #213

chawatvish commented Jan 29, 2020

AvdLee left a comment

Boris-Em left a comment

ghost commented Mar 3, 2020 •

edited by ghost

Loading

AvdLee commented Mar 4, 2020

chawatvish commented Mar 5, 2020

chawatvish commented Mar 23, 2020

alokc83 commented Apr 14, 2020

chawatvish commented Apr 15, 2020

Boris-Em left a comment •

edited

Loading

Boris-Em Apr 20, 2020

chawatvish May 25, 2020

chawatvish May 25, 2020

Boris-Em May 25, 2020 •

edited

Loading

chawatvish May 31, 2020

chawatvish Jun 10, 2020

github-actions bot commented May 21, 2020

chawatvish commented Jun 20, 2020

AvdLee commented Jul 6, 2020

Boris-Em left a comment

ghost commented Jul 22, 2020

Create individual Scanner and Review image controller #213

Create individual Scanner and Review image controller #213

Conversation

chawatvish commented Jan 29, 2020

AvdLee left a comment

Choose a reason for hiding this comment

Boris-Em left a comment

Choose a reason for hiding this comment

ghost commented Mar 3, 2020 • edited by ghost Loading

WeScanSampleProject.app: Coverage: 32.2

WeScan.framework: Coverage: 36.48

AvdLee commented Mar 4, 2020

chawatvish commented Mar 5, 2020

chawatvish commented Mar 23, 2020

alokc83 commented Apr 14, 2020

chawatvish commented Apr 15, 2020

Boris-Em left a comment • edited Loading

Choose a reason for hiding this comment

Boris-Em Apr 20, 2020

Choose a reason for hiding this comment

chawatvish May 25, 2020

Choose a reason for hiding this comment

chawatvish May 25, 2020

Choose a reason for hiding this comment

Boris-Em May 25, 2020 • edited Loading

Choose a reason for hiding this comment

chawatvish May 31, 2020

Choose a reason for hiding this comment

chawatvish Jun 10, 2020

Choose a reason for hiding this comment

github-actions bot commented May 21, 2020

chawatvish commented Jun 20, 2020

AvdLee commented Jul 6, 2020

Boris-Em left a comment

Choose a reason for hiding this comment

ghost commented Jul 22, 2020

ghost commented Mar 3, 2020 •

edited by ghost

Loading

Boris-Em left a comment •

edited

Loading

Boris-Em May 25, 2020 •

edited

Loading