Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the readme to avoid some small initial configuration issues. #222

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

Ovid-iu
Copy link

@Ovid-iu Ovid-iu commented Mar 6, 2020

From the Usage, the importing of the module is missing, and also the NSCameraUsageDescription is mandatory to be added - or else the app will crash.

I think that these may be some small issues that can be prevented for people that are just getting off the ground with iOS.

@Ovid-iu Ovid-iu requested review from AvdLee and Boris-Em as code owners March 6, 2020 13:06
@ghost
Copy link

ghost commented Mar 6, 2020

Messages
📖

View more details on Bitrise

📖 WeScan: Executed 56 tests, with 0 failures (0 unexpected) in 18.761 (18.926) seconds

Generated by 🚫 Danger Swift against ec884d4

Copy link
Contributor

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, these are great improvements! Thanks a lot for contributing 🙂

Copy link
Contributor

@Boris-Em Boris-Em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank. you for your contribution!

@Boris-Em Boris-Em merged commit b6bbf28 into WeTransfer:master Mar 9, 2020
@ghost
Copy link

ghost commented Mar 11, 2020

Congratulations! 🎉 This was released as part of Release 1.5.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants