Allow support for using an image after instantiation #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not quite sure why the Bitrise check fails, any idea what the underlying error might be? |
Closed
AvdLee
suggested changes
Jul 6, 2020
WeScan.framework: Coverage: 41.03
Generated by 🚫 Danger Swift against 41a7363 |
|
Updated PR with code review feedback! :) |
AvdLee
approved these changes
Jul 7, 2020
|
Congratulations! 🎉 This was released as part of Release 1.6.0 🚀 Generated by GitBuddy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves quad detection code into the method
detect(image:)so it can be accessed post-instantiation. This is utilized byuseImage(image:), which will push anEditScanViewControllereven after the main VC is presented. For an example of how I've been using this in production, see this video.I also made
ScannerViewControllerpublic so client code can inspect the controller hierarchy for this specific controller.