Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

! add japan language #281

Merged
merged 3 commits into from
Jan 21, 2021
Merged

! add japan language #281

merged 3 commits into from
Jan 21, 2021
+49 −0

Conversation

padgithub
Copy link
Contributor

plz merge pull request. I add Japanese language to your library.

@Boris-Em
Copy link
Contributor

Boris-Em commented Dec 4, 2020

Thank you for your contribution @padgithub!
It looks like you have a merge conflict on the project file.
Could you solve that?

Merge branch 'master' of https://github.com/padgithub/WeScan into sub…
0d1b253 
…_language/add_japan_language

# Conflicts:
#	WeScan.xcodeproj/project.pbxproj
@padgithub
Copy link
Contributor Author

i fixed conflict, plz check it

@wetransferplatform
Copy link
Collaborator

wetransferplatform commented Dec 4, 2020 •
edited
Loading

Warnings
⚠️

The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.1, but the range of supported deployment target versions is 9.0 to 14.3.99. (in target 'FBSnapshotTestCase iOS' from project 'FBSnapshotTestCase')
⚠️ Capabilities for Signing & Capabilities may not function correctly because its entitlements use a placeholder team ID. To resolve this, select a development team in the WeScanSampleProject editor. (in target 'WeScanSampleProject' from project 'WeScan')
⚠️

WeScan/Extensions/CIImage+Utils.swift#L16 - 'init(source:)' was deprecated in iOS 12.0: Core Image Kernel Language API deprecated. (Define CI_SILENCE_GL_DEPRECATION to silence these warnings)
⚠️

WeScan/Scan/CaptureSessionManager.swift#L262 - 'jpegPhotoDataRepresentation(forJPEGSampleBuffer:previewPhotoSampleBuffer:)' was deprecated in iOS 11.0
Messages
📖

View more details on Bitrise
📖 WeScan: Executed 56 tests, with 0 failures (0 unexpected) in 27.127 (27.180) seconds

Generated by 🚫 Danger Swift against 2c67ecc

@github-actions github-actions bot added the Stale label Jan 4, 2021
@github-actions github-actions bot closed this Jan 14, 2021
@AvdLee AvdLee reopened this Jan 14, 2021
@WeTransfer WeTransfer deleted a comment from github-actions bot Jan 14, 2021
@AvdLee AvdLee removed the Stale label Jan 14, 2021
@AvdLee
Copy link
Contributor

AvdLee commented Jan 21, 2021

@padgithub can you update your branch with the latest changes in master? It will fix CI 🙂

@padgithub
Copy link
Contributor Author

padgithub commented Jan 21, 2021 via email

@AvdLee
Merge branch 'master' into sub_language/add_japan_language

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
2c67ecc
@AvdLee AvdLee merged commit 39556c5 into WeTransfer:master Jan 21, 2021
@wetransferplatform
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 1.8.1 🚀

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AvdLee AvdLee

@Boris-Em Boris-Em

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@padgithub @Boris-Em @wetransferplatform @AvdLee