Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken iOS 14 AV apple api #293

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Fix broken iOS 14 AV apple api #293

merged 1 commit into from
Jan 27, 2021

Conversation

ErikGro
Copy link
Contributor

@ErikGro ErikGro commented Jan 27, 2021

Like discussed in my issue there is a bug with preview of AVCaptureSession in iOS 14. (Further details)

@wetransferplatform
Copy link
Collaborator

Warnings
⚠️ Capabilities for Signing & Capabilities may not function correctly because its entitlements use a placeholder team ID. To resolve this, select a development team in the WeScanSampleProject editor. (in target 'WeScanSampleProject' from project 'WeScan')
⚠️

The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.1, but the range of supported deployment target versions is 9.0 to 14.3.99. (in target 'FBSnapshotTestCase iOS' from project 'FBSnapshotTestCase')

⚠️

WeScan/Extensions/CIImage+Utils.swift#L16 - 'init(source:)' was deprecated in iOS 12.0: Core Image Kernel Language API deprecated. (Define CI_SILENCE_GL_DEPRECATION to silence these warnings)

⚠️

WeScan/Scan/CaptureSessionManager.swift#L263 - 'jpegPhotoDataRepresentation(forJPEGSampleBuffer:previewPhotoSampleBuffer:)' was deprecated in iOS 11.0

Messages
📖

View more details on Bitrise

📖 WeScan: Executed 56 tests, with 0 failures (0 unexpected) in 22.798 (22.846) seconds

WeScan.framework: Coverage: 36.5

File Coverage
CaptureSessionManager.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against ddf4310

Copy link
Contributor

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting this out, the fix makes sense to me!

@AvdLee AvdLee merged commit 9787c79 into WeTransfer:master Jan 27, 2021
@wetransferplatform
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 1.8.1 🚀

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants