Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #357

Merged
merged 12 commits into from
Jun 21, 2023
Merged

Fix typos #357

merged 12 commits into from
Jun 21, 2023

Conversation

valeriyvan
Copy link
Contributor

No description provided.

Copy link
Contributor

@BasThomas BasThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@wetransferplatform
Copy link
Collaborator

wetransferplatform commented Jun 20, 2023

Fails
🚫

CIRectangleDetectorTests.testCorrectlyDetectsAndReturnsQuadilateral():
failed - Snapshot does not match reference.

@−
"/Users/vagrant/git/Tests/WeScanTests/Snapshots/CIRectangleDetectorTests/testCorrectlyDetectsAndReturnsQuadilateral.1.png"
@+
"/Users/vagrant/Library/Developer/CoreSimulator/Devices/D7CA41A8-547E-4DC0-9C53-FF5A41928CA5/data/tmp/CIRectangleDetectorTests/testCorrectlyDetectsAndReturnsQuadilateral.1.png"

To configure output for a custom diff tool, like Kaleidoscope:

SnapshotTesting.diffTool = "ksdiff"

Actual perceptual precision 0.69906247 is less than required 0.97

🚫

VisionRectangleDetectorTests.testCorrectlyDetectsAndReturnsQuadilateral():
failed - Snapshot does not match reference.

@−
"/Users/vagrant/git/Tests/WeScanTests/Snapshots/VisionRectangleDetectorTests/testCorrectlyDetectsAndReturnsQuadilateral.1.png"
@+
"/Users/vagrant/Library/Developer/CoreSimulator/Devices/D7CA41A8-547E-4DC0-9C53-FF5A41928CA5/data/tmp/VisionRectangleDetectorTests/testCorrectlyDetectsAndReturnsQuadilateral.1.png"

To configure output for a custom diff tool, like Kaleidoscope:

SnapshotTesting.diffTool = "ksdiff"

Newly-taken snapshot does not match reference.

Warnings
⚠️ 'gray' was deprecated in iOS 13.0: renamed to 'UIActivityIndicatorView.Style.medium'
⚠️ 'blackTranslucent' was deprecated in iOS 13.0: Use UIBarStyleBlack and set the translucent property to YES instead.
⚠️

'init(source:)' was deprecated in iOS 12.0: Core Image Kernel Language API deprecated. (Define CI_SILENCE_GL_DEPRECATION to silence these warnings)

⚠️ 'blackTranslucent' was deprecated in iOS 13.0: Use UIBarStyleBlack and set the translucent property to YES instead.
⚠️ 'isAutoStillImageStabilizationEnabled' was deprecated in iOS 13.0
⚠️ 'jpegPhotoDataRepresentation(forJPEGSampleBuffer:previewPhotoSampleBuffer:)' was deprecated in iOS 11.0
⚠️ Please provide a summary in the Pull Request description
Messages
📖 WeScanTests: Executed 60 tests (2 failed, 0 retried, 0 skipped) in 12.904 seconds
📖 Slowest test: RectangleFeaturesFunnelTests/testAddAlternateImage() (4.214s)
📖 Slowest test: RectangleFeaturesFunnelTests/testAddPreviouslyDisplayedRect() (3.089s)
📖 Slowest test: RectangleFeaturesFunnelTests/testAddMinUnderThreshold() (3.017s)
📖

View more details on Bitrise

Code Coverage Report

Name Coverage
WeScan 37.76% ⚠️

SwiftLint found issues

Severity File Reason
Warning CaptureSessionManager.swift:259 The disabled 'function_parameter_count' rule should be re-enabled before the end of the file (blanket_disable_command)

Generated by 🚫 Danger Swift against 8af804f

@AvdLee
Copy link
Contributor

AvdLee commented Jun 21, 2023

Thanks a lot, these changes are always welcome! 🙌

@AvdLee AvdLee merged commit 392ad18 into WeTransfer:master Jun 21, 2023
@valeriyvan valeriyvan deleted the typo branch June 21, 2023 20:27
@wetransferplatform
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 3.0.0-beta.1 🚀

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants