Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make __wasi_linkcount_t a uint64_t #134

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Make __wasi_linkcount_t a uint64_t #134

merged 1 commit into from
Nov 14, 2019

Conversation

cjihrig
Copy link

@cjihrig cjihrig commented Nov 9, 2019

@cjihrig
Copy link
Author

cjihrig commented Nov 14, 2019

Ping @sunfishcode?

@sunfishcode
Copy link
Member

We need to figure out the right way to coordinate this with the overall switch to wasi_snapshot_preview0. Would it make sense to have a branch that we can make all the changes on, and then merge them all into master at once?

@cjihrig
Copy link
Author

cjihrig commented Nov 14, 2019

That sounds like a good approach. That would include this PR, #106, and something for WebAssembly/WASI#125 (I was going to PR that as well, but wanted to see how this PR went first). I think those are all of the changes for the current snapshot.

@sunfishcode
Copy link
Member

Ok, I've now created https://github.com/CraneStation/wasi-libc/tree/wasi_snapshot_preview1 so we can do PRs there.

@cjihrig cjihrig changed the base branch from master to wasi_snapshot_preview1 November 14, 2019 20:42
@cjihrig
Copy link
Author

cjihrig commented Nov 14, 2019

Thanks. I've updated this PR to target that branch.

sunfishcode
sunfishcode approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@sunfishcode sunfishcode merged commit f1889e4 into WebAssembly:wasi_snapshot_preview1 Nov 14, 2019
@cjihrig cjihrig deleted the linkcount branch November 14, 2019 23:58
sunfishcode pushed a commit that referenced this pull request Nov 22, 2019
@cjihrig @sunfishcode
Make __wasi_linkcount_t a uint64_t (#134)
06b3788 
Refs: WebAssembly/WASI#127
sunfishcode added a commit that referenced this pull request Nov 22, 2019
@sunfishcode
Wasi snapshot preview1 (#140)
446cb3f 
* Make __wasi_linkcount_t a uint64_t (#134)

Refs: WebAssembly/WASI#127

* Generate the WASI interface from witx.

This replaces the hand-maintained <wasi/core.h> header with a
<wasi/api.h> generated from witx.

Most of the churn here is caused by upstream WASI renamings; hopefully
in the future ABI updates will be less noisy.
@Shillaker Shillaker mentioned this pull request Apr 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunfishcode sunfishcode sunfishcode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjihrig @sunfishcode