-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use local-web-server package for all servers #473
base: main
Are you sure you want to change the base?
Use local-web-server package for all servers #473
Conversation
✅ Deploy Preview for webkit-speedometer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good to me!
Here are some suggestions, tell me what you think!
resources/newssite/news-next/dist/_next/static/IbZpY6lpxNCTHGQFLD2XQ/_buildManifest.js
Outdated
Show resolved
Hide resolved
Looks like the CI failed too |
- await server startup status - enable logging
I've just noticed that we changed the default port from 7000 to 8000 previously. Are folks ok with this in general? (No strong opinion from my side) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good to me, thanks !
I just think you forgot to commit the new version of package-lock.json
after the latest changes to package.json
, so please do that before landing :-)
Thanks!
…01-22_test_server_headers
BTW I still see 2.15.3 instead of 2.15.4. |
I never know what the command for this is |
npm ci
to regenerate package-lock and sort package.json entries