Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate protoflux groups maintain connections to original copies #984

Open
code807 opened this issue Dec 23, 2023 · 4 comments
Open

Duplicate protoflux groups maintain connections to original copies #984

code807 opened this issue Dec 23, 2023 · 4 comments
Labels
New Feature A new addition, whose complexity hasn't been evaluated yet

Comments

@code807
Copy link

code807 commented Dec 23, 2023

Describe the bug?

When duplicating selected groups of ProtoFlux nodes, the duplicates maintain connections to the original ProtoFlux.

To Reproduce

  • Create and select any multi-node ProtoFlux group
  • Duplicate the selection

Expected behavior

The duplicate nodes should have connections between each other rather than connections to their originals.

Screenshots

Resonite_xMXMkragu4
Resonite_hsW2s7Pb8W
Resonite_5yNvX3CgtC

Resonite Version Number

Beta 2023.12.21.1127

What Platforms does this occur on?

Windows

What headset if any do you use?

No response

Log Files

DESKTOP-1E2V3A8 - 2023.12.21.1127 - 2023-12-23 00_35_53.log

Additional Context

No response

Reporters

code807

@code807 code807 added the bug Something isn't working as intended. label Dec 23, 2023
@Nytra
Copy link

Nytra commented Dec 23, 2023

Possibly related #907

@art0007i
Copy link

Possibly related #907

I don't think that issue is related at all. I'm pretty sure this issue happens because when you grab multiple items and duplicate them each one is duplicated individually, rather than all at once

@shiftyscales
Copy link
Collaborator

Agreed- #907 is a separate issue.

I don't think this is a bug, however. There are situations in which it makes sense for a duplicated node to point to its original connections- you are duplicating the nodes exactly as they are.

It is already possible to duplicate ProtoFlux in the way you are asking- you would just have to have it packed into a slot, and duplicate that slot instead.

This may be something that would fall under #599 which would unify selection systems in Resonite, and improve multi-select functionality.

@shiftyscales shiftyscales added New Feature A new addition, whose complexity hasn't been evaluated yet and removed bug Something isn't working as intended. labels Jan 19, 2024
@shiftyscales shiftyscales removed their assignment Jan 19, 2024
@JackTheFoxOtter
Copy link

JackTheFoxOtter commented Jan 19, 2024

I would definitely consider this a bug. You're holding a group of objects with internal references. Duplicating them should properly re-assign the references in the same way references within duplicated hierarchies are reassigned everywhere else in Resonite.

It is also currently impossible to hold a group of ProtoFlux and bring it with you into a different world by focusing there without the node connections breaking, I assume for the same underlying issue this ticket is describing.

Banane9 added a commit to ResoniteModdingGroup/CommunityBugFixCollection that referenced this issue Jan 22, 2025
Banane9 added a commit to ResoniteModdingGroup/CommunityBugFixCollection that referenced this issue Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature A new addition, whose complexity hasn't been evaluated yet
Projects
None yet
Development

No branches or pull requests

5 participants