Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add client name and version #25

Merged
merged 1 commit into from
Feb 12, 2019
Merged

add client name and version #25

merged 1 commit into from
Feb 12, 2019

Conversation

tw0517tw
Copy link
Contributor

@tw0517tw tw0517tw commented Feb 1, 2019

@codecov-io
Copy link

codecov-io commented Feb 1, 2019

Codecov Report

Merging #25 into master will increase coverage by 0.32%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   77.61%   77.94%   +0.32%     
==========================================
  Files           6        6              
  Lines          67       68       +1     
  Branches        5        5              
==========================================
+ Hits           52       53       +1     
  Misses         14       14              
  Partials        1        1
Impacted Files Coverage Δ
src/utils/createFetchFromToken.js 60% <100%> (+4.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 967df24...4aab78e. Read the comment docs.

@@ -11,6 +13,8 @@ module.exports = function createFetchFromToken(token, opts) {
uri,
fetch,
headers: {
'apollographql-client-name': 'ynlu-sdk-node',
Copy link
Member

@wtflink wtflink Feb 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer ynlu-node-sdk

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, prefer ynlu-node-sdk

@kpman kpman merged commit 3dffc62 into master Feb 12, 2019
@kpman kpman deleted the clientname branch February 12, 2019 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants