Fix comet connections not starting a recv after the connect req closes #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That was only a recent change .... |
paddybyers
added a commit
that referenced
this pull request
Dec 14, 2015
Fix comet connections not starting a recv after the connect req closes
|
I tried it with a pretty old ably-js, same behaviour. (or d'you mean it was a recent realtime change?) |
|
thanks |
yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #180. Cause was just that there was no
self.recv()inconnectRequest.on('complete'). I did find one lurking inonConnect, though, which AFAICS doesn't make sense -- whenonConnectfires, the/connectstream is still good for another 59 or so seconds. So I'm guessing it just got put in the wrong place.(a bit ashamed that I'd never noticed before that comet connections had never worked for more than a minute. possible future enhancement: a longrunning.test.js suite that tests that everything works as it should after a few /recv cycles, that websocket connections don't die after a few minutes, etc. perhaps run in a separate ci job, or maybe by ci-browsers-all in parallel with the saucelabs tests)